Skip to content

[fix]: error when node has no internal IP for nodebalancer backend#379

Closed
cbbond wants to merge 1 commit into
mainfrom
no-private-ip-err
Closed

[fix]: error when node has no internal IP for nodebalancer backend#379
cbbond wants to merge 1 commit into
mainfrom
no-private-ip-err

Conversation

@cbbond
Copy link
Copy Markdown
Contributor

@cbbond cbbond commented May 1, 2025 •
edited
Loading

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@github-actions github-actions Bot added the bugfix for any bug fixes in the changelog. label May 1, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 72.92%. Comparing base (bc67c49) to head (25689d1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cloud/linode/loadbalancers.go 55.00% 6 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   73.15%   72.92%   -0.24%     
==========================================
  Files          15       15              
  Lines        2675     2685      +10     
==========================================
+ Hits         1957     1958       +1     
- Misses        547      553       +6     
- Partials      171      174       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cbbond cbbond closed this May 13, 2025
@cbbond cbbond deleted the no-private-ip-err branch May 13, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bugfix for any bug fixes in the changelog.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cbbond